Allow for Jira in title #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankywahl
force-pushed
the
allow-for-jira-in-title
branch
from
38aa925
to
bb54e6f
Compare
Since a PR is opened, it cannot have it's base branch edited. That means that if we forget to put a PR number, we have to close it and open it again. With this change, it is now possible to put the ticket in the PR title to be picked up as well and linked properly.
frankywahl
force-pushed
the
allow-for-jira-in-title
branch
from
bb54e6f
to
72f9561
Compare
pmrotule
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
I thought it was a requirement to have the branch name starting with the Jira ticket number in order to automatically create the link to the pull request in Jira, but according to the documentation, it will also detects it in the PR title.
I was aware of the limitation from using the branch name like you mentioned in your PR description and we tried to prevent it by adding a pre-commit hook. That being said, your solution is much better! No pre-commit hook needed 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for Jira ticket in title
Since a PR is opened, it cannot have it's base branch edited. That means
that if we forget to put a PR number, we have to close it and open it
again.
With this change, it is now possible to put the ticket in the PR title
to be picked up as well and linked properly.